Container module gets rebuilt when ignor...
# 💻｜contributings
swift-garage-61180
10/30/2023, 2:43 PM@curved-intern-91221 Thank for flagging this. I'm kind of surprised this isn't already covered by unit tests, but we should investigate & fix ASAP.
I think this should be relatively straightforward.
Do you feel like having a go yourself, or should we find someone else?
https://github.com/garden-io/garden/issues/5317
swift-garage-61180
10/30/2023, 2:45 PMFor one reason or another, our current unit tests for includes & excludes for
VCSHandlerc
curved-intern-91221
10/30/2023, 2:47 PM@swift-garage-61180 I havent; chcked the tests yet. Now I'm looking into another issue - https://github.com/garden-io/garden/issues/5083
curved-intern-91221
10/30/2023, 2:48 PMIt looks like we dont pss the right var context to the template string resolver when we load pulumi varfiles. I think I'll need some help with that task too
s
swift-garage-61180
10/30/2023, 2:49 PMOk cool, I'm happy to pair on that tomorrow if you like
swift-garage-61180
10/30/2023, 2:49 PMShould I put something in our calendars?
swift-garage-61180
10/30/2023, 2:55 PMIs the problem that
modulesswift-garage-61180
10/30/2023, 2:58 PMEssentially, what we need here is to pass a different config context when initialising the plugin context for the Pulumi plugin commands—a config context that includes the
modulesactionsswift-garage-61180
10/30/2023, 2:59 PMThis config context determines the template variables available when the plugin (here: Pulumi) resolves template strings using
ctx.resolveTemplateStringsc
curved-intern-91221
10/30/2023, 6:31 PM@swift-garage-61180 thanks! I've created a calendar event, tomorrow at 1pm. Pls lmk if it doesn't work for you
3 Views