Unversioned config keys
# 💻｜contributings
swift-garage-61180
10/27/2023, 11:03 AMStarting a thread on the "unversioned config keys" feature we were talking about yesterday 🧶
a
astonishing-tomato-18259
10/27/2023, 11:08 AMThanks. I am currently building a proof of concept where we can ignore certain keys for action version calculation.
s
swift-garage-61180
10/27/2023, 11:08 AMInitially, maybe it would make sense to just have this be a config field on actions (not on the spec, but a framework-level field on action configs).
It would also simplify things to not allow template strings in this field (i.e. the config paths to ignore should be hardcoded).
The config might look something like this:
Copy code
kind: Deploy
name: api
noCache: [
["spec", "someKey", "hostName"]
]
spec:
someKey:
hostName: "${var.baseUrl}/api" # <--- omitted before hashing
...swift-garage-61180
10/27/2023, 11:12 AM... actually, looks like we can allow template strings without problems (would be nice to e.g. be able to read this from a var).
Just like the other top-level action fields (which use
ActionConfigContexta
astonishing-tomato-18259
10/27/2023, 11:53 AMAnother option i was thinking to mention the variables in
noCache Copy code
kind: Deploy
name: api
noCache:
- var,baseUrl
spec:
someKey:
hostName: "${var.baseUrl}/api" # <--- omitted before hashing
...astonishing-tomato-18259
10/27/2023, 12:37 PMPushed a commit with a PoC. Tested on the quickstart example and currently the variable to ignore is hard coded as
Copy code
const ignoreVars = ["base-hostname"]astonishing-tomato-18259
10/27/2023, 12:44 PMThe result of above looks like this
Copy code
deploy.api - ignoredKeys: [ 'spec.ingresses.0.hostname' ]
deploy.vote - ignoredKeys: [ 'spec.ingresses.0.hostname', 'spec.env.HOSTNAME' ]s
swift-garage-61180
10/27/2023, 12:48 PMAha yeah, I think this sort of string query format makes sense.