https://garden.io logo
#🌱|help-and-getting-started
Not able to use local valueFiles when using repositoryUrl Helm Module
# 🌱|help-and-getting-started
b

bright-policeman-43626

11/28/2022, 5:28 AM
Hey guys! Just creating this one for visibility, hopefully somebody can take a look at this one, also if there’s a possibility of getting some context on the Code that handles this part I might be able to try to implement a solution for it! https://github.com/garden-io/garden/issues/3367
Hey guys, just looking if there's anything I can help to further triage this issue? ❤️ @swift-garage-61180 @curved-intern-91221
c

curved-intern-91221

12/15/2022, 12:21 PM
Hi @bright-policeman-43626! Sorry for the late reply. We have a draft PR to address the issue above: https://github.com/garden-io/garden/pull/3445 It looks like it's enough to weaken the path validation conditions. We'll double check to make sure there is no regression.
b

bright-policeman-43626

12/15/2022, 11:57 PM
You guys are amazing thank you! Is there anything that I can do to help testing this? Should I build this PR locally to test?
c

curved-intern-91221

12/16/2022, 8:29 AM
@bright-policeman-43626 it would be great if you can build that PR and test it locally. By the way, the PR can have some side effects. We have been allowing only sub-paths as valid
valueFiles
to make sure that the hashes of the value files are factored into the version hash. With this PR, it should be possible to use arbitrary paths as
valueFiles
. But, if you try to modify files that are located outside the module working dir, then the
garden build
command might not rebuild the image, because the version hash won't change. Please let us know if you get any unexpected behaviour while testing the PR.
q

quaint-dress-831

12/21/2022, 8:36 AM
@bright-policeman-43626 have you had a chance to build and test the PR?
a

ancient-diamond-80011

01/09/2023, 9:59 AM
Sorry for the delay and thanks for your patience! This should be fixed in #3445 and available in a fresh edge pre-release of garden, as well as coming to the stable release in the next few weeks.
Caveat: this might introduce some issues for the project hash and "has anything changed since last deployment" detection - if you run into any, please report here https://github.com/garden-io/garden/issues/3487 thank you! 🙇‍♂️
b

bright-policeman-43626

01/09/2023, 8:05 PM
Thanks a lot! ❤️ this will be shipped in 0.13 right?
a

ancient-diamond-80011

01/10/2023, 1:04 PM
earlier - it will be in the next 0.12.xxx patch release, likely some time next week
b

bright-policeman-43626

01/10/2023, 4:15 PM
Thanks a lot!
a

ancient-diamond-80011

01/11/2023, 3:11 PM
thanks a lot for reporting and helping make garden better ❤️