revisit check-docs and link checking

Question

we should probably revisit our `check docs` CI step at some point the current implementation of the link checking is causing quite a bunch of spurious failures

ancient-diamond-80011 · Answer

here s a fresh job failure for checking a link to a tweet button https app circleci com pipelines github garden io garden 16917 workflows 37c52eb8 d876 46ab 8ffc e73d2990ffab jobs 288714

ancient-diamond-80011 · Answer

https cdn discordapp com attachments 1105172907929370746 1105173236381139075 Screenshot 2023 05 08 at 19 43 39 png

cold-jordan-68753 · Answer

That link seems to return a 400 we might need to change remove it

ancient-diamond-80011 · Answer

for the specific issue sure it s originally from a template readme not created by us anyway but i meant this more generally we re seeing quite a lot of flakiness and errors in our link checking

ancient-diamond-80011 · Answer

additionally the current form of link checking combined with how our docs work have been a blocker for us to bump the actual version number in the bonsai branch package json files to `0 13 x`

ancient-diamond-80011 · Answer

made a PR for the specific issue at hand but we should probably still consider revisiting it in broader terms some time later https github com garden io garden pull 4205