https://github.com/garden-io/garden/pull/4150
Cou...
# 💻｜contributinga
alert-helicopter-61082
05/02/2023, 1:04 PMhttps://github.com/garden-io/garden/pull/4150
Could someone pick up the TODOs here?
c
calm-family-29323
05/02/2023, 1:14 PMon it
a
alert-helicopter-61082
05/02/2023, 1:41 PMSeems some integ tests are failing as well. Don't quite have time to dig in today, but let me know if you run into walls.
alert-helicopter-61082
05/03/2023, 9:15 AMI wonder if we should just close out the PR (pending review and tests ofc) and then take care of the TODOs separately? There's a task for each TODO on the project board already
alert-helicopter-61082
05/03/2023, 9:16 AMI've just rebased the PR at least, we'll see if there are test failures related to it (was a bit hard to tell before)
c
calm-family-29323
05/03/2023, 9:23 AMyeah I think it makes sense as we have aggregate issues for both example projects and docs where these points can be added
2 Views