https://garden.io logo
Powered by
b

brief-restaurant-63679

04/24/2023, 8:54 AM
Hey all I think the Core version is still set to 0.12.x on the 0.13 branch. This causes some issues when testing against Cloud which checks for the client version. Shouldn't we update it to 0.13-alpha or similar? I'm assuming this is just read from the package.json but not entirely sure how updating it jives with the release process.
a

ancient-diamond-80011

04/24/2023, 9:05 AM
ideally yes, sadly in practice there are some friction points here
some version naming schemes make yarn unhappy, and others make our documentation links (and the check-docs script) unhappy
because our docs assume that there exists a pushed tag on github so that it can be an in-tree permalink
we do have a 
0.13.0-0
pre-release pushed as a tag to github nowadays, but if we made that the version in the code and for yarn, and made changes to the docs and links, those links can be broken until we make another pre-release with the new tag and the new edited docs
having a link checker is great, but it does come with its drawbacks as well - especially when combined with development versions
the other alternative of just using 
0.13
with no further qualifiers as the version, as that's the name of our long-lived branch and would exist on github, doesn't work because it's not a valid semver version for node/yarn purposes
b

brief-restaurant-63679

04/24/2023, 9:39 AM
Ah ok. Maybe we should set the version explicitly then for API calls but not mess with the package files.
a

ancient-diamond-80011

04/24/2023, 10:03 AM
yeah i don't know what the best (or least-worst) solution here would be, but it could be nice to figure out something better for the long term as well
perhaps we could reconsider our documentation links and their versioning in general at some point
another side effect right now is when you make a release you'll get 37 files changed because the version string changes in all those links, and i'm not sure if that's ideal
Powered by