chilly-gigabyte-83853
04/12/2023, 10:11 AMstatus.state
for deploy
action has changed to be status.deployStatus
. This is a problem since we are assuming all actions have status.state
as property. Can we name it back as it was? cc @alert-helicopter-61082 @swift-garage-61180swift-garage-61180
04/12/2023, 10:42 AMcurved-intern-91221
04/12/2023, 10:55 AMcalm-family-29323
04/12/2023, 11:06 AMaction.state
though. Are you sure you are using the correct field? The change was made to the detail object on the action result (to avoid confusion just like these where we have two different fields with the same name)swift-garage-61180
04/12/2023, 11:07 AMstate
field is still there at the top level, right?cold-jordan-68753
04/12/2023, 11:07 AMswift-garage-61180
04/12/2023, 11:08 AMstate
field is intended for that.calm-family-29323
04/12/2023, 11:09 AMcold-jordan-68753
04/12/2023, 11:10 AMevent.payload.status.state
swift-garage-61180
04/12/2023, 11:11 AMcalm-family-29323
04/12/2023, 11:11 AMevent.payload.state
swift-garage-61180
04/12/2023, 11:11 AMstatus.state
is not ActionState
either.DeployState
type has different values from ActionState
, for one. And status.state
has different types for the build, deploy, test and run status events.
That's the reason we included the state: ActionState
field at the top level of all the status event payloads—that way, we have a consistent set of states for all the action types.chilly-gigabyte-83853
04/12/2023, 11:32 AMstatus.state
has a different type, but do all action have a status.state
?
If so, can we call it always status.state
and not status.deployState
, status.state
, etc?cold-jordan-68753
04/12/2023, 11:33 AM.status.state
in 0.13, just .state
swift-garage-61180
04/12/2023, 11:36 AMActionState
type that's used at the top level of all the status event payloads).chilly-gigabyte-83853
04/12/2023, 11:51 AMpolite-fountain-28010
04/12/2023, 1:08 PMdeploying
, fetched
, built
etc instead of just running
and success
if I understood the distinction correctly from the thread.
I also think it makes sense that we follow through with the alignment of property names and just call it state
and not deployState
just like we got rid of deployStartedAt
etcswift-garage-61180
04/12/2023, 1:25 PMchilly-gigabyte-83853
04/12/2023, 1:28 PMbrief-restaurant-63679
04/12/2023, 3:00 PMalert-helicopter-61082
04/12/2023, 3:27 PMchilly-gigabyte-83853
04/12/2023, 3:48 PMswift-garage-61180
04/12/2023, 3:54 PM