Here is the draft PR with default timeout values: ...
# 💻｜contributingc
curved-intern-91221
04/11/2023, 1:32 PMHere is the draft PR with default timeout values: https://github.com/garden-io/garden/pull/4066
I've created a list of to-be-discussed questions in the PR's description.
cc @swift-garage-61180 @calm-family-29323 @alert-helicopter-61082 @big-spring-14945
curved-intern-91221
04/11/2023, 1:49 PMLet's discuss in the thread
curved-intern-91221
04/12/2023, 8:50 AMDoes it make sense to have
timeoutconfigmappersistentvlumeclaimDeploykubernetesDeployc
calm-family-29323
04/12/2023, 8:52 AMI think it makes sense for PVC-s as the they can definitely get stuck in the deploy state. Not sure about the configmaps though, but I don't think it can hurt
s
swift-garage-61180
04/12/2023, 9:17 AMThey could time out e.g. when there are network problems or an auth issue. There's almost always a way for deploys to time out, one way or another.
swift-garage-61180
04/12/2023, 9:18 AMSo IMHO it makes sense for timeouts to be a framework-native primitive.
Doesn't seem particularly urgent, though—there's more pressing stuff for us to work on in Core.
a
alert-helicopter-61082
04/12/2023, 3:30 PMFeels like basically every action kind should have a native timeout field. I forget why exactly it wasn't made native for all of them to begin with. I do think we actually have to consider this quickly because we may need to move some fields around (basically
spec.timeouttimeoutspec.timeoutc
curved-intern-91221
04/13/2023, 10:12 AMWell, I can avoid these changes in https://github.com/garden-io/garden/pull/4066
curved-intern-91221
04/13/2023, 10:13 AMbasically, the PR above already sets default values for timeouts. But, in TS interfaces we still have to keep the
timeoutcurved-intern-91221
04/13/2023, 10:13 AMWe can do the
spec.timeouttimeout5 Views